Add README #9
Merged
Add README #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
kubevirt-bot
added
size/L
approved
phoracek
requested changes
Mar 5, 2020
README.md
Outdated
| @@ -1 +1,157 @@ | |||
| # macvtap CNI | |||
|
|
|||
| ## Overview | |||
There was a problem hiding this comment.
No need for another header, just keep overview right under the main heading
README.md
Outdated
| ``` | ||
|
|
||
| The CNI config json allows the following parameters: | ||
| * `name` (string, required): the name of the network. When used within ai |
README.md
Outdated
| containers: | ||
| - name: busybox | ||
| image: busybox | ||
| command: ["/bin/sleep", "123"] |
There was a problem hiding this comment.
Sleep longer, this can be easily missed when I go for a coffee
README.md
Outdated
| containers: | ||
| - name: busybox | ||
| image: busybox | ||
| command: ["/bin/sleep", "123"] |
jcaamano
force-pushed
the
master
branch
2 times, most recently
from
53e764c to
1f17285
Compare
maiqueb
requested changes
Mar 5, 2020
Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
kubevirt-bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/release-note-none Sorry about this hook. We need to either disable it or leverage it. |
kubevirt-bot
added
release-note-none
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jaime Caamaño Ruiz [email protected]
What this PR does / why we need it:
Adds README.
Special notes for your reviewer: